fix: During browser agent injection, don't set ContentLength if headers have already been sent. (#2051) #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs have already been sent. Resolves #2051
tippmar-nr
requested review from
jaffinito,
nrcventura,
nr-ahemsath,
chynesNR and
dotnet-agent-team-bot
Codecov Report
@@ Coverage Diff @@
## main #2059 +/- ##
=======================================
Coverage 81.06% 81.06%
=======================================
Files 394 394
Lines 24678 24678
Branches 2963 2963
=======================================
Hits 20004 20004
Misses 3889 3889
Partials 785 785 |
nrcventura
reviewed
Nov 13, 2023
...NewRelic/Agent/Extensions/Providers/Wrapper/AspNetCore6Plus/BrowserInjectingStreamWrapper.cs
Show resolved
Hide resolved
jaffinito
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.
Description
Adds a check during browser agent injection for ASP.NET Core 6+ to determine if response headers have already been sent and only sets
Response.ContentLengthif headers have not been sent.Resolves #2051
Author Checklist
Reviewer Checklist