Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StackExchangeRedis2PlusWrapper can create multiple SessionCache instances #2180

Closed
tippmar-nr opened this issue Jan 9, 2024 · 1 comment · Fixed by #2186
Closed

StackExchangeRedis2PlusWrapper can create multiple SessionCache instances #2180

tippmar-nr opened this issue Jan 9, 2024 · 1 comment · Fixed by #2186
Labels
bug Something isn't working

Comments

@tippmar-nr
Copy link
Member

Description
Recent customer-supplied memory dumps have revealed that the agent is holding 2 instances of SessionCache when we only intend for there to be a single instance. This would appear to be a race condition when StackExchange.Redis.ConnectionMultiplexer.CreateMultiplexer is called multiple times in quick succession, or it may be related to an agent restart.

In any case, we should consider adding some locking in the RegisterProfiler() callback in ConnectWrapperV2.cs

Expected Behavior
The agent should use a single instance of the SessionCache

For Maintainers Only or Hero Triaging this bug
Suggested Priority (P1,P2,P3,P4,P5):
P3
Suggested T-Shirt size (S, M, L, XL, Unknown):
S

@tippmar-nr tippmar-nr added the bug Something isn't working label Jan 9, 2024
@workato-integration
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant