Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCSampler - CountData calculated as negative causes exception #264

Closed
nr-ahemsath opened this issue Sep 30, 2020 · 1 comment · Fixed by #550
Closed

GCSampler - CountData calculated as negative causes exception #264

nr-ahemsath opened this issue Sep 30, 2020 · 1 comment · Fixed by #550
Assignees
Labels
bug Something isn't working

Comments

@nr-ahemsath
Copy link
Member

Description

We are unsure of the reason, but the GC Sampler is trying to create a count metric that is a negative value. As a result, the GC Sampler shuts down (because too many exceptions have been thrown).

Here is where the exception is being thrown from:

throw new ArgumentException(CannotBeNegative, nameof(callCount));

Expected Behavior

Since many of the count values are delta values from the prior value, intercept a negative value and record it as 0 in the event.
When doing so, add a log message (finest) indicating the Metric and requested value that was switched to 0.

Steps to Reproduce

Unknown at this point.

@JoshuaColeman
Copy link

JoshuaColeman commented Apr 11, 2021

Hey @angelatan2! I have a potential solution for this in #525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants