Update all ubuntu 18.04 runners to 22.04 #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nr-ahemsath
changed the title
nr-ahemsath
added
the
chore
JcolemanNR
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
Awesome, this should keep our CI running past the 18.04 deprecation coming up in a few months! I was surprised that there weren't more issues with this migration, but after looking closer, we are building our linux amd64 profiler on ubuntu:14.04, and like you mentioned our arm64 profiler is using the run-on-arch action targeting ubuntu:18.04.
We should probably refactor our ARM64 build to a dockerfile so it can be built locally in the longrun (and we wouldn't need to use the run-on-arch action potentially), but these changes look good to keep the lights on! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github is deprecating its
ubuntu-18.04runners: actions/runner-images#6002Upgrade all workflow references of
ubuntu-18.04toubuntu-22.04.Note: was not able to upgrade the
distroparameter in therun-on-archjobs for building and testing the ARM version of the Linux profiler, due to build problems. Doing this will take more effort as it's unclear what the cause of the problem is, but it seems to be in the general area of cmake/clang/llvm tooling. This doesn't seem to be a problem since we don't have any indication that therun-on-archaction is deprecating theubuntu18.04distro option.