fix: Revert RabbitMQ HandleBasicDeliver instrumentation change from #1972. Resolves #2047 #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tippmar-nr
requested review from
jaffinito,
nrcventura,
nr-ahemsath,
chynesNR and
dotnet-agent-team-bot
nrcventura
approved these changes
Dec 5, 2023
chynesNR
approved these changes
Dec 5, 2023
nrcventura
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.
Description
Reverts a change to the
HandleBasicDeliverinstrumentation point that was made in #1972, but which caused issues as reported in #2047.We would have to make this change eventually in any case, as the instrumented class appears to have been removed in the most recent (presently unrelease) Rabbit MQ .NET Client codebase.
Author Checklist
Reviewer Checklist