Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add missing test cases for DisableFileSystemWatcher setting. #2558

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

jaffinito
Copy link
Member

Description

Add a pair of missing test cases for DisableFileSystemWatcher.

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.59%. Comparing base (a6c4e74) to head (27154dc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2558   +/-   ##
=======================================
  Coverage   80.59%   80.59%           
=======================================
  Files         459      459           
  Lines       28927    28927           
  Branches     3177     3177           
=======================================
  Hits        23315    23315           
  Misses       4822     4822           
  Partials      790      790           
Flag Coverage Δ
Agent 81.49% <ø> (ø)
Profiler 72.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jaffinito jaffinito merged commit 97484b1 into main Jun 17, 2024
93 checks passed
@jaffinito jaffinito deleted the chore/add-missed-filesystem-watcher-tests branch June 17, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants