Update maximum Span Event samples to 2000 #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuqtran88
approved these changes
Sep 2, 2021
vuqtran88
added a commit
that referenced
this pull request
Sep 8, 2021
* Remove CacheStatsReporter (#692) * Add agent identifier string ".NET Agent" to agent settings payload (#698) * 9x remove deprecated configs (#697) * Add spanEvents.maxSamplesStored configuration * Initial helper methods; removed analyticEvents.* * Obsolete analytics/transactionEvents.maximumSamplesPerMinute * Remove parameterGroups.* * Removed requestParameters.ignore * Remove transactionTracer.captureAttributes * Remove errorCollector.captureAttributes * Remove browserMonitoring.captureAttributes; cleanup 1. Remove browserMonitoring.captureAttributes and associated tests 2. Remove a test missed re: errorCollector.captureAttributes 3. Change "Deprecated" to "Disabled" in Configuration.xsd documentation 4. Removed now-unused LogDeprecationWarnings method from DefaultConfiguration.cs 5. Went back to specifying the replacement config for transactionTracer/errorCollector/browserMonitoring.captureAttributes to be transactionTracer/errorCollector/browserMonitoring.attributes.enabled since that is how the associated code in DefaultConfiguration works. * Remove two integration tests that only existed to test a config we removed * Fix failing HttpClientInstrumentation test * Update CHANGELOG Co-authored-by: Vu Tran <vtran@newrelic.com> * Update default config to use DT over CAT (#700) * Enabled DT in the default config over CAT. * Updated DT and CAT related tests to accommodate new default settings. * Updated RestSharp CAT tests with CAT verbage. * Fixed and simplified tests CAT/DT configuration. * Remove customer facing obsolete methods (#687) * Remove only customer facing obsolete methods * Cut a little deeper on removing obsolete APIs * Remove un-needed tests * Revert "Cut a little deeper on removing obsolete APIs" This reverts commit fef45ed. * merge in logging/removed api method changes * merge more changes in * Upgrade integration test apps to agent api v8.41.1. Adapt some tests to use new APIs * Remove old test * Fix another integration test failure * Update selenium... Turns out I had just disabled IE 11 in my windows features while disabling hyperv... * CR Feedback * Re-order/update changelog * Make maximum Span Events configurable, and use new cycle and maximums sent from server (#701) * Added new span_event_harvest_config from server, and updated to use it. * Updated unit tests for new span event harvest settings. * Enforces min limit for span event sample storage. * change ReportPeriodMs to int from int? * tabified for consistency. * update CHANGELOG.md * include PR link. * Revert "Enforces min limit for span event sample storage." because the Connect Service will enforce the min limit instead. This reverts commit 1ba5aa4. Co-authored-by: Vu Tran <vtran@newrelic.com> * Generates "Supportability/SpanEvent/Limit" supportability metric. (#706) * Generates "Supportability/SpanEvent/Limit" supportability metric. Removes unused code. * fixes unit tests. * fixes double "Supportability" prefix. add an integration test. * Add Castle.Monorail deprecation statement (#710) * Add Castle.Monorail deprecation statement * Updated maximum span event samples to 2000. (#705) * Update `errorCollector.ignoreErrors` to `errorCollector.ignoreClasses` (#709) * Updated to ignoreClasses and removed unused ignoreErrors entries. * Updated unit tests. * Updated integration tests. * Added back in unit test and changed expected result. * Update CHANGELOG.md Co-authored-by: Vu Tran <56414817+vuqtran88@users.noreply.github.com> * Disable RequestParameters config (#711) * Disable RequestParameters config * Removed unneeded CaptureRequestParameters property. * Updated unit tests with new setting and removed unnecessary ones. * - Update integration tests to use ConfigModifier for attribute include/excludes. - Convert RequestParameters configuration usage to attributes include "request.parameters.*" * changelog updated Co-authored-by: Basil Abusamrah <tehbio@gmail.com> * Update CHANGELOG.md * Fixed changelog sort. Co-authored-by: Alex Hemsath <57361211+nr-ahemsath@users.noreply.github.com> Co-authored-by: Alex Hemsath <ahemsath@newrelic.com> Co-authored-by: Basil <tehbio@gmail.com> Co-authored-by: Josh Coleman <83677148+JcolemanNR@users.noreply.github.com> Co-authored-by: Jacob Affinito <jaffinito@newrelic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #703 with the
spanEvent.maximumSamplesStoreddefault updated to 2000.