Fix agent hang on startup. #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onOnTheseMethods list. Removes confusing/incorrect logging message.
tehbio
approved these changes
Oct 14, 2021
JcolemanNR
approved these changes
Oct 14, 2021
Closed
tehbio
added a commit
that referenced
this pull request
Oct 25, 2021
* Added commands to remove expired cert. (#748) * Update mongodb tests (#747) * Updates MongDb driver to v2.13.1. Adds CoreIndexManger related tests to test against a net core test application. Refactors tests. * fixes failed test endpoints due to incorrectly exercises mongodb apis. * Expands AsyncCursorsTests tests to NetCore test application. * Expands IndexManagerTests tests to the netcore mongodb test application. * Expands the rest of MongoDb tests to test against .net core test application. * removes irrelevant ref. * Fix agent hang on startup. (#753) * Adds "System.Net.HttpWebRequest.GetResponse" to the DeferInitializationOnTheseMethods list. Removes confusing/incorrect logging message. * Update CHANGELOG.md * fixes grammar. * Re-enable unbounded tests in workflow (#765) * Added GHA step to run integration tests on linux-arm64. * Updated CHANGELOG.md Co-authored-by: Vu Tran <56414817+vuqtran88@users.noreply.github.com> Co-authored-by: Alex Hemsath <57361211+nr-ahemsath@users.noreply.github.com>
tehbio
added a commit
that referenced
this pull request
Oct 26, 2021
* A workflow to build linux arm64 profiler (#742) * Adds new profiler build job for arm64 Updates existing linuc job name to callout out arch Updates conditionals to match new job names Updates _profilerBuild deletion list to include new paths * Updates build_functions.ps1 to support new folder names * Removed -march from CMAKELIST * Move to https and no caching for wget (#744) * Netcore targeted integration tests (#752) * Builds but some int tests fail locally; want to test in GHA * Multi-targeted integration test project * Conditional inclusion of WCF project * Various Linux compatibility fixes, WIP * Linux debugging, WIP, will not work on Windows * Dynamic detection of Windows vs. Linux * Added commands to remove expired cert. (#748) * More windows/linux differences * Make IsLinux a property * Update mongodb tests (#747) * Updates MongDb driver to v2.13.1. Adds CoreIndexManger related tests to test against a net core test application. Refactors tests. * fixes failed test endpoints due to incorrectly exercises mongodb apis. * Expands AsyncCursorsTests tests to NetCore test application. * Expands IndexManagerTests tests to the netcore mongodb test application. * Expands the rest of MongoDb tests to test against .net core test application. * removes irrelevant ref. * Remove RIDs from test app project files; handle Process.HasExited exception * Attempt to solve .exe issue Co-authored-by: Basil <tehbio@gmail.com> Co-authored-by: Vu Tran <56414817+vuqtran88@users.noreply.github.com> * Updates to produce Linux ARM64 artifacts (#745) * ArtifactBuilder updates for new linux artifacts. * Script + workflow updates for Linux ARM64 artifacts. * Fixed Artifact default value. * Fix for expired CA. * Added commands to remove expired cert. (#748) * Updated to handle multiple file checksums. * Added Processor Architecture to Environment payload. (#755) * Arm64 publishing for debian (#756) * renaming deploy.yml to deploy_agent.yml to better call out its function * Updates repoman-promote.bash for arm64 * Updates deploy-packages.bash for arm64 * Updates debain conf files for arm64 * Undo deploy rename * Use named pipes for test app ipc (#762) * Using named pipes for test application process control * Get test using AspNetCoreMvcBasicRequestsApplication to pass on Windows * Refactor test app lifecycle management into helper library * Refactor lifecycle management for AspNetCore3BasicWebApiApp * Refactored several apps to use shared lifecycle management code * oops, missed a spot * Refactor SerilogSumologic app * Move net core attribute instrumentation tests to use ConsoleMF app * Remove NetCoreAttributeInstrumentationFixture * Unify framework and core attribute instrumentation tests * Arm64 testing fixes. * Arm64 testing fixes continued. * Updates broken local build to match GHA (#764) Removes old linux-release folder Adds linux-arm64-release with the .so from the old folder Adds linux-arm64-release with the so from https://github.com/newrelic/newrelic-dotnet-agent/actions/runs/1356682557 Updates profiler build.ps1 with the new-correct path (this is only used locally) * Fix linux integration test failures (#766) * Using named pipes for test application process control * Get test using AspNetCoreMvcBasicRequestsApplication to pass on Windows * Refactor test app lifecycle management into helper library * Refactor lifecycle management for AspNetCore3BasicWebApiApp * Refactored several apps to use shared lifecycle management code * oops, missed a spot * Refactor SerilogSumologic app * Move net core attribute instrumentation tests to use ConsoleMF app * Remove NetCoreAttributeInstrumentationFixture * Unify framework and core attribute instrumentation tests * Attempt to fix Linux issues with EnvironmentTests * Add comment about nullable total ram field * Update Rejit tests to use Path.Combine instead of explicit backslash * Use Path.Combine in InterfaceDefaultsInstrumentationTests * Use Path.Combine in DetachWrapperTests * Use Path.Combine in AspNetCoreMvcAsyncTests * Path.Combine ALL THE THINGS * Somehow AspNet5BasicWebApiApplication wasn't in the solution so it was missed when making all the named pipe changes * Fix framework/core inconsistency in headers tests * Update test app for netcore thread profiling tests to .NET 5 to support Linux testing * Add a method to skip tests on Linux and apply them to the logging tests * Fix test class cleanup error for skipped test * Added GHA step to run integration tests on linux-arm64 (#767) * Added commands to remove expired cert. (#748) * Update mongodb tests (#747) * Updates MongDb driver to v2.13.1. Adds CoreIndexManger related tests to test against a net core test application. Refactors tests. * fixes failed test endpoints due to incorrectly exercises mongodb apis. * Expands AsyncCursorsTests tests to NetCore test application. * Expands IndexManagerTests tests to the netcore mongodb test application. * Expands the rest of MongoDb tests to test against .net core test application. * removes irrelevant ref. * Fix agent hang on startup. (#753) * Adds "System.Net.HttpWebRequest.GetResponse" to the DeferInitializationOnTheseMethods list. Removes confusing/incorrect logging message. * Update CHANGELOG.md * fixes grammar. * Re-enable unbounded tests in workflow (#765) * Added GHA step to run integration tests on linux-arm64. * Updated CHANGELOG.md Co-authored-by: Vu Tran <56414817+vuqtran88@users.noreply.github.com> Co-authored-by: Alex Hemsath <57361211+nr-ahemsath@users.noreply.github.com> * CHANGELOG.md update. Co-authored-by: Jacob Affinito <jaffinito@newrelic.com> Co-authored-by: Alex Hemsath <57361211+nr-ahemsath@users.noreply.github.com> Co-authored-by: Vu Tran <56414817+vuqtran88@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A customer experienced a deadlock in their app on startup. This is because the customer is using a configuration builder which made external request using HttpWebRequest on startup. This call triggered the agent to start but agent couldn’t start because it tried to read app settings which depends on the configuration builder. This caused the external call to hang then the app. The fix is to add "System.Net.HttpWebRequest.GetResponse" to the DeferInitializationOnTheseMethods list to delay this external call instrumentation after the agent successfully starts.
This PR also removes confusing/incorrect logging message.