Add specification for exporter user-agent names. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-feld
force-pushed
the
user-agent-names
branch
from
e222a62
to
9d15407
Compare
|
We should make it clear that this are appended to the user agent that the telemetry SDK provides, and probably link to the appropriate doc in the telemetry sdk specs about how to accomplish it. |
jkwatson
approved these changes
Nov 26, 2019
justinfoote
approved these changes
Nov 26, 2019
This was referenced Dec 3, 2019
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The telemetry SDK specifications introduced the ability to append product names and versions to the SDK's base user agent string (newrelic/newrelic-telemetry-sdk-specs#8).
In this PR, we define a specification for unified user-agent strings based on the exporter product in use.