Address PR comments

newrelic · Oct 22, 2020 · 084a7ff · 084a7ff
1 parent faf3b73
commit 084a7ff
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/record/record.go b/record/record.go
@@ -42,8 +42,7 @@ func RemapRecord(inputRecord FluentBitRecord, inputTimestamp interface{}, plugin
 	if !ok {
 		source = "BARE-METAL"
 	}
-	_, ok = outputRecord["plugin"]
-	if !ok {
+	if _, ok = outputRecord["plugin"]; !ok {
 		outputRecord["plugin"] = map[string]string{
 			"type":    "fluent-bit",
 			"version": pluginVersion,

diff --git a/record/record_test.go b/record/record_test.go
@@ -56,9 +56,9 @@ var _ = Describe("Out New Relic", func() {
 				time.Now(),
 			}
 			expectedType := "something"
-			pluginMapIn := make(map[string]string)
-			pluginMapIn["type"] = expectedType
-			inputMap["plugin"] = pluginMapIn
+			inputMap["plugin"] = map[string]string{
+				"type": expectedType,
+			}
 			foundOutput := RemapRecord(inputMap, inputTimestamp, pluginVersion)
 			pluginMap := foundOutput["plugin"].(map[string]string)
 			Expect(pluginMap["type"]).To(Equal(expectedType))
@@ -102,7 +102,7 @@ var _ = Describe("Out New Relic", func() {
 
 		It("Correctly handles a JSON array in a []interface{}", func() {
 			// Given
-			inputRecord := map[interface{}]interface{}{
+			inputMap := map[interface{}]interface{}{
 				"nestedArray": []interface{}{
 					map[interface{}]interface{}{
 						"stringField":  "value1",
@@ -116,7 +116,7 @@ var _ = Describe("Out New Relic", func() {
 			}
 
 			// When
-			foundOutput := parseRecord(inputRecord)
+			foundOutput := parseRecord(inputMap)
 
 			// Then
 			expectedOutput := map[string]interface{}{