Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dry run requests #2

Closed
invidian opened this issue Apr 28, 2021 · 1 comment · Fixed by #55
Closed

Support dry run requests #2

invidian opened this issue Apr 28, 2021 · 1 comment · Fixed by #55
Assignees
Labels
feature request Categorizes issue or PR as related to a new feature or enhancement.
Milestone

Comments

@invidian
Copy link
Contributor

As injection webhook modifies ClusterRoleBinding and creates Secrets, we should support dry run requests to avoid creating side-effects.

We should also check if it's desired to generate a mutation patch as a response when dry run requests is received.

@invidian invidian added the feature request Categorizes issue or PR as related to a new feature or enhancement. label Apr 28, 2021
@invidian invidian added this to the v0.1.0 milestone Apr 28, 2021
@invidian invidian modified the milestones: v0.1.0, v0.2.0 May 7, 2021
@paologallinaharbur
Copy link
Member

Notice that the following requests commands already to not hit the operator:

k run pod --image nginx --dry-run=client
k run pod --image nginx --dry-run

However the server-side requests are hitting the operator causing the creation of secrets and the update of ClusterRoleBindings

k run pod --image nginx --dry-run=server
k run pod --image nginx --server-dry-run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Categorizes issue or PR as related to a new feature or enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants