Allowing any numeric metric in Kafka / Connect

newrelic · Jun 22, 2023 · 17c9ce2 · 17c9ce2
1 parent 93a77be
commit 17c9ce2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/...nts-metrics-2.0.0/src/main/java/com/nr/instrumentation/kafka/NewRelicMetricsReporter.java b/...nts-metrics-2.0.0/src/main/java/com/nr/instrumentation/kafka/NewRelicMetricsReporter.java
@@ -54,8 +54,8 @@ public void run() {
                     Map<String, Object> eventData = new HashMap<>();
                     for (final Map.Entry<String, KafkaMetric> metric : metrics.entrySet()) {
                         Object metricValue = metric.getValue().metricValue();
-                        if (metricValue instanceof Double) {
-                            final float value = ((Double) metricValue).floatValue();
+                        if (metricValue instanceof Number) {
+                            final float value = ((Number) metricValue).floatValue();
                             if (kafkaMetricsDebug) {
                                 AgentBridge.getAgent().getLogger().log(Level.FINEST, "getMetric: {0} = {1}", metric.getKey(), value);
                             }

diff --git a/...ka-clients-metrics-3.0.0/src/main/java/com/nr/instrumentation/kafka/MetricsScheduler.java b/...ka-clients-metrics-3.0.0/src/main/java/com/nr/instrumentation/kafka/MetricsScheduler.java
@@ -63,8 +63,8 @@ public void run() {
                 Map<String, Object> eventData = new HashMap<>();
                 for (final Map.Entry<String, KafkaMetric> metric : nrMetricsReporter.getMetrics().entrySet()) {
                     Object metricValue = metric.getValue().metricValue();
-                    if (metricValue instanceof Double) {
-                        final float value = ((Double) metricValue).floatValue();
+                    if (metricValue instanceof Number) {
+                        final float value = ((Number) metricValue).floatValue();
                         if (KAFKA_METRICS_DEBUG) {
                             AgentBridge.getAgent().getLogger().log(Level.FINEST, "getMetric: {0} = {1}", metric.getKey(), value);
                         }

diff --git a/...1.0.0/src/main/java/com/nr/instrumentation/kafka/connect/KafkaConnectMetricsReporter.java b/...1.0.0/src/main/java/com/nr/instrumentation/kafka/connect/KafkaConnectMetricsReporter.java
@@ -75,8 +75,8 @@ void harvest() {
             Map<String, Object> eventData = METRICS_AS_EVENTS ? new HashMap<>() : Collections.emptyMap();
             for (final Map.Entry<String, KafkaMetric> metric : metrics.entrySet()) {
                 Object metricValue = metric.getValue().metricValue();
-                if (metricValue instanceof Double) {
-                    final float value = ((Double) metricValue).floatValue();
+                if (metricValue instanceof Number) {
+                    final float value = ((Number) metricValue).floatValue();
                     if (KAFKA_METRICS_DEBUG) {
                         NewRelic.getAgent().getLogger().log(Level.FINEST, "getMetric: {0} = {1}", metric.getKey(), value);
                     }