Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable log4j1 tests for Java 21 #1547

Closed
meiao opened this issue Oct 12, 2023 · 2 comments · Fixed by #1615
Closed

Reenable log4j1 tests for Java 21 #1547

meiao opened this issue Oct 12, 2023 · 2 comments · Fixed by #1615
Labels
estimate Issue needing estimation

Comments

@meiao
Copy link
Contributor

meiao commented Oct 12, 2023

Description

MDC does not seem to work in Log4J1 when using Java 21.
That feature does not work with Java 1, but the logic to check if it is running in Java 1 is flawed.
https://github.com/apache/logging-log4j1/blob/b7e9154128cd4ae1244c877a6fda8f834a0f2247/src/main/java/org/apache/log4j/helpers/Loader.java#L42-L50

Because of this, the tests that check the MDC functionality fail in Java 21. Thus they have been disabled for Java 21.

It is likely that the functionality will work with Java 21.0.1, so we should reenable the tests then.

Acceptance Criteria

Either:

  • the tests run and pass;
  • add a comment explaining that that functionality will no longer work.
@workato-integration
Copy link

@meiao meiao mentioned this issue Oct 12, 2023
3 tasks
@kford-newrelic kford-newrelic added the estimate Issue needing estimation label Nov 16, 2023
@workato-integration
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
estimate Issue needing estimation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants