Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 21 compatibility #1546

Merged
merged 14 commits into from Oct 12, 2023
Merged

Java 21 compatibility #1546

merged 14 commits into from Oct 12, 2023

Conversation

meiao
Copy link
Contributor

@meiao meiao commented Oct 12, 2023

Overview

Changes to make sure that the agent works with Java 21.

  • all tests that ran with Java 20 now run with 21;
  • new instrumentation module due to changes in java.net.Socket;
  • adapting instrumentation due to change in lambda's .toString().

Related Github Issue

Resolves #1498

Checks

  • Your contributions are backwards compatible with relevant frameworks and APIs.
  • Your code does not contain any breaking changes. Otherwise please describe.
  • Your code does not introduce any new dependencies. Otherwise please describe.

@meiao meiao requested a review from a team October 12, 2023 19:15
Copy link
Contributor

@jbedell-newrelic jbedell-newrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should create a ticket to remind us to turn the Log4J1 tests back on when 21.0.1 is released.

@codecov-commenter
Copy link

Codecov Report

Merging #1546 (f747237) into main (0e70cdf) will increase coverage by 0.04%.
Report is 46 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1546      +/-   ##
============================================
+ Coverage     70.58%   70.63%   +0.04%     
- Complexity     9754     9782      +28     
============================================
  Files           814      816       +2     
  Lines         39300    39419     +119     
  Branches       5967     5978      +11     
============================================
+ Hits          27739    27842     +103     
- Misses         8870     8879       +9     
- Partials       2691     2698       +7     
Files Coverage Δ
...va/com/newrelic/agent/config/JavaVersionUtils.java 91.30% <100.00%> (ø)

... and 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@meiao
Copy link
Contributor Author

meiao commented Oct 12, 2023

Ticket to reenable the tests
#1547

@meiao meiao merged commit 5708812 into main Oct 12, 2023
103 checks passed
@meiao meiao deleted the java-21 branch October 12, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support Java 21 OOTB
4 participants