feat: add thread.id attribute to Spans #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiao
force-pushed
the
sdaubin/span-thread-id
branch
from
e8300bc
to
69b54e2
Compare
obenkenobi
reviewed
Sep 25, 2023
newrelic-agent/src/test/java/com/newrelic/agent/tracers/DefaultSqlTracerClmTest.java
Show resolved
Hide resolved
obenkenobi
reviewed
Sep 25, 2023
newrelic-agent/src/test/java/com/newrelic/agent/tracers/DefaultSqlTracerTest.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1513 +/- ##
=========================================
Coverage 70.60% 70.60%
- Complexity 9744 9747 +3
=========================================
Files 813 813
Lines 39264 39268 +4
Branches 5962 5963 +1
=========================================
+ Hits 27722 27727 +5
+ Misses 8857 8854 -3
- Partials 2685 2687 +2
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
meiao
approved these changes
Sep 25, 2023
jtduffy
approved these changes
Sep 25, 2023
jtduffy
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Knowing the thread id of different spans allows the UI to accurately calculate the exclusive time of segments.
thread.idis a standard OTel attribute and they recommend that it be reported for all spans.https://opentelemetry.io/docs/specs/otel/trace/semantic_conventions/span-general/
Related Github Issue
Include a link to the related GitHub issue, if applicable
Testing
The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
Checks
[ ] Are your contributions backwards compatible with relevant frameworks and APIs?
[ ] Does your code contain any breaking changes? Please describe.
[ ] Does your code introduce any new dependencies? Please describe.