Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add okhttp-4.4 instrumentation #16

Merged
merged 1 commit into from Aug 13, 2020
Merged

Add okhttp-4.4 instrumentation #16

merged 1 commit into from Aug 13, 2020

Conversation

jeffalder
Copy link
Contributor

Changes from 4.0:

  1. getResponseWithInterceptorChain is now internal, so the Java method name changed.
  2. RealCall moved from okhttp3 to okhttp3.internal.connection

@jeffalder jeffalder added this to In progress in Java Engineering Board Aug 12, 2020
tspring
tspring approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@tspring tspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ahornerr
Copy link

I was able to confirm this works correctly with OkHTTP 4.7.2.

image

@jeffalder jeffalder merged commit 095e277 into main Aug 13, 2020
Java Engineering Board automation moved this from In progress to Done Aug 13, 2020
@jeffalder jeffalder deleted the okhttp-4.4 branch August 13, 2020 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tspring tspring tspring approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Java Engineering Board
Archived in project
Java Engineering Board
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeffalder @ahornerr @tspring