Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1715 http client5 fixes #1719

Merged
merged 4 commits into from Feb 2, 2024
Merged

1715 http client5 fixes #1719

merged 4 commits into from Feb 2, 2024

Commits on Feb 2, 2024

  1. Modified the instrumentation to do instanceof checks before casting, … 

    …this should resolve the NPE.

Also added a case for the Message<HttpResponse, T> case.
Updated tests
    @jbedell-newrelic
    jbedell-newrelic committed Feb 2, 2024
    Copy the full SHA
    1d724f9 View commit details
    Browse the repository at this point in the history

  2. Quick null check on the response, just in case

    @jbedell-newrelic
    jbedell-newrelic committed Feb 2, 2024
    Copy the full SHA
    5e6a05b View commit details
    Browse the repository at this point in the history

  3. PR review changes

    @jbedell-newrelic
    jbedell-newrelic committed Feb 2, 2024
    Copy the full SHA
    08383ce View commit details
    Browse the repository at this point in the history

  4. And another null check

    @jbedell-newrelic
    jbedell-newrelic committed Feb 2, 2024
    Copy the full SHA
    b3943b6 View commit details
    Browse the repository at this point in the history