Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check HttpHost instance for null prior to dereferencing it #1722

Merged
merged 1 commit into from Feb 5, 2024

Conversation

jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Feb 5, 2024

Resolves #1717

Retrieve the URI instance from the HttpPost instance unless it's null, then pull the required info from the HttpRequest instance.

@jtduffy jtduffy requested a review from a team February 5, 2024 14:12
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb80af4) 70.73% compared to head (e5f0945) 70.76%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1722      +/-   ##
============================================
+ Coverage     70.73%   70.76%   +0.02%     
- Complexity     9926     9931       +5     
============================================
  Files           828      828              
  Lines         39855    39855              
  Branches       6033     6033              
============================================
+ Hits          28193    28203      +10     
+ Misses         8931     8927       -4     
+ Partials       2731     2725       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtduffy jtduffy merged commit fb9a813 into main Feb 5, 2024
103 checks passed
@jtduffy jtduffy deleted the httpclient-npe branch February 5, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants