1793 dynamo db double externals #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…http external call from being recorded, and thus doubling up on externals.
|
Resolves: #1793 |
jtduffy
approved these changes
Mar 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1827 +/- ##
=============================================
- Coverage 70.87% 36.11% -34.76%
+ Complexity 9973 4863 -5110
=============================================
Files 829 829
Lines 39984 39984
Branches 6058 6058
=============================================
- Hits 28340 14442 -13898
- Misses 8916 23633 +14717
+ Partials 2728 1909 -819 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the DB operations as leaf=true to prevent the subsequent (and duplicate) HTTP external from being recorded.