Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-regex SQL checks #1887

Merged
merged 8 commits into from
May 8, 2024
Merged

Non-regex SQL checks #1887

merged 8 commits into from
May 8, 2024

Conversation

kanderson250
Copy link
Contributor

This PR incorporates the changes from the custom jar we built to prevent unnecessary regex checks when parsing SQL. A customer had reported latency with r2dbc drivers, and removing the extra regex checks resolved their issue.

Instead of performing a regex check for all operations, we now do a simple String contains on the operation name, before continuing with the match.

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 70.68%. Comparing base (a16c459) to head (645037f).
Report is 308 commits behind head on main.

Files Patch % Lines
...ewrelic/agent/bridge/datastore/R2dbcOperation.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1887      +/-   ##
============================================
- Coverage     70.75%   70.68%   -0.08%     
+ Complexity     9930     9877      -53     
============================================
  Files           828      828              
  Lines         39855    39851       -4     
  Branches       6033     6064      +31     
============================================
- Hits          28201    28170      -31     
- Misses         8928     8952      +24     
- Partials       2726     2729       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanderson250 kanderson250 merged commit afda029 into main May 8, 2024
111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants