#424 - Add Scala instrumentation and Scala API for Monix Tasks #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te logging to use logger and only log on FINEST log setting
# Conflicts: # .github/workflows/GHA-Scala-Functional-Tests.yaml
instrumentation/newrelic-scala-monix-api/src/main/scala/com/newrelic/monix/api/Util.scala
Outdated
Show resolved
Hide resolved
newrelic-scala-monix-api/src/main/scala/com/newrelic/monix/api/TraceOps.scala
Outdated
Show resolved
Hide resolved
newrelic-scala-monix-api/src/main/scala/com/newrelic/monix/api/TraceOps.scala
Outdated
Show resolved
Hide resolved
newrelic-scala-monix-api/src/main/scala/com/newrelic/monix/api/TraceOps.scala
Outdated
Show resolved
Hide resolved
richard-gibson
approved these changes
Nov 18, 2021
twcrone
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related Github Issue
Include a link to the related GitHub issue, if applicable:
Scala instrumentation - Monix async framework support
#424
Testing
Added functional tests to newrelic-scala-monix-api project to test Monix task scenarios. Add functional test to Scala functional test workflow. Ran tests successfully locally and on GHA. Tested cross building to Scala 2.11, 2.12 and 2.13. Used gradle verify instrumentation task to verify instrumentation from Monix version 3.0.0 to lastest version 3.4.0 for Scala 2.11, 2.12, 2.13 and 3.
Checks
[X] Are your contributions backwards compatible with relevant frameworks and APIs? Yes
[X] Does your code contain any breaking changes? Please describe. No
[X] Does your code introduce any new dependencies? Please describe. Yes new projects with related Monix dependencies