Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional project for Play WS 2.6.0 to support 2.13 #594

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

GDownes
Copy link
Contributor

@GDownes GDownes commented Dec 3, 2021

Overview

Added instrumentation project to capture HTTP requests via Play WS 2.60+ for Scala 2.13

Related Github Issue

#527

Testing

Added unit tests to validate instrumentation.
Ran verify instrumentation Gradle task to validate other versions.
Created sample application featuring HTTP requests via Play WS 2.60+ in Scala 2.13 and viewed results in New Relic One.

Screenshot 2021-12-06 at 13 49 12

Checks

[X] Are your contributions backwards compatible with relevant frameworks and APIs? Yes
[X] Does your code contain any breaking changes? Please describe. No
[X] Does your code introduce any new dependencies? Please describe. No

@GDownes GDownes marked this pull request as ready for review December 6, 2021 13:51
@kford-newrelic kford-newrelic added this to Triage in Java Engineering Board via automation Dec 6, 2021
@kford-newrelic kford-newrelic moved this from Triage to Needs Review in Java Engineering Board Dec 6, 2021
@twcrone twcrone merged commit 73b1b51 into main Dec 6, 2021
Java Engineering Board automation moved this from Needs Review to Done Dec 6, 2021
@twcrone twcrone deleted the play-ws-2.6.0_2.13 branch December 6, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants