Move linking mbean to jmxservice #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfuller1
reviewed
Sep 18, 2020
| @@ -97,6 +92,7 @@ public void addJmxAttributeProcessor(JmxAttributeProcessor attributeProcessor) { | |||
| @Override | |||
| protected void doStart() { | |||
| if (enabled) { | |||
| registerAgentMBeans(); | |||
There was a problem hiding this comment.
don't we want to have a specific config for this? Not just jmx as a whole
There was a problem hiding this comment.
See #62 buddy. We want to do small incremental/progressive changes.
gfuller1
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #61
This moves the registration of the linking metadata mbean into the jmxservice.
I picked up a little bit of campsite cleanup around the
ServiceFactoryusage in theJMXServiceas well.