R2DBC MariaDB Instrumentation #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twcrone
reviewed
Mar 23, 2022
instrumentation/r2dbc-mariadb/src/main/java/com/nr/agent/instrumentation/r2dbc/R2dbcUtils.java
Outdated
Show resolved
Hide resolved
twcrone
reviewed
Mar 23, 2022
twcrone
reviewed
Mar 24, 2022
instrumentation/r2dbc-h2/src/main/java/com/nr/agent/instrumentation/r2dbc/R2dbcUtils.java
Show resolved
Hide resolved
twcrone
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
R2DBC MariaDB Instrumentation - Instrumentation to capture execute calls when using MariaDB via R2DBC.
Instruments the MariaDB MariaDBStatement child classes a R2DBC Statement interface implementation. Higher level R2DBC Statement interface doesn't provide enough information to instrument more generically.
Related Github Issue
#197
Testing
PR includes unit tests created to exercise instrumentation
Checks
[X] Are your contributions backwards compatible with relevant frameworks and APIs? New instrumentation
[X] Does your code contain any breaking changes? Please describe. No
[X] Does your code introduce any new dependencies? Please describe. Yes, new instrumentation dependencies in new project.