Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring webflux #93

Merged
merged 5 commits into from
Oct 29, 2020
Merged

Spring webflux #93

merged 5 commits into from
Oct 29, 2020

Conversation

tspring
Copy link
Contributor

@tspring tspring commented Oct 23, 2020

Spring-webflux instrumentation changes based on openTelemetry. We add a Token to the reactive Context and link/expire for onNext, onError, onComplete subscriptions. Should handle cases where multiple WebClient calls occur asynchronously like so:

return serviceA.getData()
                .map(service -> Response.builder().service(service).build())
                .flatMap(serviceB::getData)
                .flatMap(serviceC::getData)
                .doOnNext(this::saveResponse);

@abhihub abhihub added this to In progress in Java Engineering Board Oct 29, 2020
tspring added a commit that referenced this pull request Oct 29, 2020
…s on spring-webflux and netty-reactor instrumentation in pr #93
@tspring tspring mentioned this pull request Oct 29, 2020
@tspring tspring marked this pull request as ready for review October 29, 2020 19:47
Copy link
Contributor

@jasonjkeller jasonjkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tspring tspring merged commit f412e6f into main Oct 29, 2020
Java Engineering Board automation moved this from In progress to Done Oct 29, 2020
@tspring tspring deleted the spring-webflux branch October 29, 2020 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants