Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEWRELIC-4422 updated apollo server plugin tests to deleted cached agent from prop or symbol on require.cache #227

Merged
merged 1 commit into from Nov 9, 2022

Conversation

bizob2828
Copy link
Member

Proposed Release Notes

Links

Details

The apollo server plugin tests will eventually fail when we release the new agent version that removes the dunder __NR props and replaces with symbols. This fix will work with both

To test

npm ci
npm run integration

To test with symbols

# In agent repo
npm ci
npm link

# In PR branch
npm ci
npm link newrelic
npm run integration

@bizob2828 bizob2828 added the dev:tests Indicates only updates to tests label Nov 9, 2022
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #227 (737f457) into main (2228850) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files           4        4           
  Lines         642      642           
=======================================
  Hits          635      635           
  Misses          7        7           
Flag Coverage Δ
integration-tests-14.x 92.67% <ø> (ø)
integration-tests-16.x 92.67% <ø> (ø)
integration-tests-18.x 92.67% <ø> (ø)
unit-tests-14.x 54.04% <ø> (ø)
unit-tests-16.x 54.04% <ø> (ø)
unit-tests-18.x 54.04% <ø> (ø)
versioned-tests-14.x 94.39% <ø> (ø)
versioned-tests-16.x 94.39% <ø> (ø)
versioned-tests-18.x 94.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jordigh jordigh merged commit 3313f8b into newrelic:main Nov 9, 2022
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Nov 9, 2022
@github-actions github-actions bot mentioned this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only updates to tests
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants