chore: add node.js v16 #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hi @dnalborczyk thanks for your contribution! I see the build is breaking and there are several issues which are a little complicated. I did cherry pick your 1 commit to add node 16 to the matrix for running all various tests and there are less failures. I can help get to the bottom of this, I just wanted to let you know I'm taking a look |
Merged
This was referenced May 13, 2021
|
@dnalborczyk once again, thanks for your contribution 🙏🏻 . I incorporated your changes in #77 but as you can see, I had to do a bit more work to get our CI happy with supporting Node.js v16. I'm going to close this but will definitely give you a shoutout. |
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Release Notes
Links
Details