feat(dataloader): create an example app that uses Apollo, koa, a dataloader and Mongo #68
Conversation
| "graphql-tag": "^2.12.6", | ||
| "koa": "^2.14.2", | ||
| "koa-bodyparser": "^4.4.0", | ||
| "mongodb": "^5.5.0", |
There was a problem hiding this comment.
we don't support mongo v5 just yet. I would downgrade and re-test. you might be starting off with an incorrect baseline
There was a problem hiding this comment.
Thanks.
This really should have been a WIP, as there were other problems, such as not using the ESM loader, nor the Apollo plugin. I'm just going to rebase to add those.
jordigh
force-pushed
the
dataloader
branch
2 times, most recently
from
b375212
to
9dec9ec
Compare
|
This is ready for a second review. As far as I can tell, this works just fine and the DynamoDB calls are showing up fine and dandy in DT.
|
…loader, and Mongo or DynamoDB Except for the dataloader, these are all things we instrument, so we should be seeing spans for all of them once our instrumentation is working. And as far as I can tell... we do.
There was a problem hiding this comment.
This looks good, I verified I see traces and relevant spans for dynamo/mongo when using the dataloader. I tried to revive the pared down app to see if I could see issues but I don't think it actually is using dataloader. I think this application will serve as a good talking point for users who state they have issues with dataloader
Except for the dataloader, these are all things we instrument, so we should be seeing spans for all of them once our instrumentation is working.