Symfony5 support

[b-viguier]

Summary

The NR php agent supports Symfony framework from version 1 to 4. Since version 5, some breaking changes may prevent NR extension to report all expected information. Is SF5 support in your Roadmap?

Desired Behavior

• Auto-detect SF5 framework usage
• Report exceptions

Possible Solution

SF5 replaces the ExceptionListener class by ErrorListener (see UPGRADE instructions). Unfortunately, NR extension is explicitly looking for ExceptionListener class, to wrap it and report exceptions.

newrelic-php-agent/agent/fw_symfony4.c

Lines 184 to 187 in 3f93ee4

	nr_php_wrap_user_function(
	NR_PSTR("Symfony\\Component\\HttpKernel\\"
	"EventListener\\ExceptionListener::onKernelException"),
	nr_symfony4_exception TSRMLS_CC);

By detecting SF5 framework, we could change wrapped function… if I understand the code correctly 😅

Additional context

None.

Thanks for your work 👍

[joaojacome]

IMO the framework-specific functions should be delegated to a composer package, instead of locking the frameworks in the extension.

[piotrantosik]

Hi, anyone tries setup newrelic with symfony 5? It's works when I set newrelic.framework = "symfony4"?
Right now I use with newrelic.preload_framework_library_detection = false but in this setup I don't see proper transactions.

[b-viguier]

@piotrantosik We are using https://github.com/ekino/EkinoNewRelicBundle, it's a little redundant with built-in framework support, but at least transaction names are correctly handled

[Ak-x]

Closing this issue per #256