Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Agent builds for 8.0 are missing ZTS support #172

Closed
joshuabenuck opened this issue Jun 2, 2021 · 6 comments
Closed

PHP Agent builds for 8.0 are missing ZTS support #172

joshuabenuck opened this issue Jun 2, 2021 · 6 comments
Labels
bug Something isn't working
Projects
PHP/C Engineering Board

Comments

@joshuabenuck
Copy link
Contributor

joshuabenuck commented Jun 2, 2021 •
edited

As noted by @ralt here, ZTS support for 8.0 is missing in our agent builds.

The --enable-maintainer-zts flag was renamed --enable-zts. On all of our build nodes, this change was not made when building PHP 8.0. This led to the ZTS agent builds for PHP 8.0 not being compiled with ZTS support.
@joshuabenuck joshuabenuck added the bug Something isn't working label Jun 2, 2021
@joshuabenuck joshuabenuck mentioned this issue Jun 2, 2021
Closed
@joshuabenuck joshuabenuck added this to Triage - tag + prioritize. in PHP/C Engineering Board via automation Jun 2, 2021
matthiaz added a commit to platformsh/platformsh-docs that referenced this issue Jun 25, 2021
@matthiaz
Newrelic does not work on php8
48031c2 
newrelic/newrelic-php-agent#172 needs to be fixed, only then can we roll it out.
@matthiaz matthiaz mentioned this issue Jun 25, 2021
Merged
@Fahmy-Mohammed
Copy link
Contributor

Fixed in version 9.18 of the agent

PHP/C Engineering Board automation moved this from Triage - tag + prioritize. to Done Aug 17, 2021
@vupham-lc
Copy link

vupham-lc commented Aug 18, 2021 •
edited

We can not install php agent new relic for our amazon linux 2 in this morning because of this error:
Package newrelic-php5-common.noarch 0:9.18.0.302-1 will be installed --> Finished Dependency Resolution Error: Package: newrelic-php5-9.18.0.302-1.x86_64 (newrelic) Requires: libpcre.so.3()(64bit)

We can install normally with version v9.17
Maybe this fixed lead to the error?

@zsistla
Copy link
Contributor

zsistla commented Aug 18, 2021

@vupham-lc , thank you for bringing this to our attention. Are you using the ZTS or non-ZTS binary? What version of PHP?

@vupham-lc
Copy link

Hi,
We are using PHP 7.2.
Im not sure we are using ZTS or not. How can i check it?
Maybe not?
@.*** /]# php -i | grep zts
@.*** /]#

@zsistla
Copy link
Contributor

zsistla commented Aug 19, 2021 •
edited

@vupham-lc ,
Thank you for the additional details. Looking into this issue now.

@lazarenkoalexey lazarenkoalexey mentioned this issue Nov 11, 2021
Closed
@zsistla zsistla reopened this Nov 17, 2021
PHP/C Engineering Board automation moved this from Done to Triage - tag + prioritize. Nov 17, 2021
@mfulb mfulb moved this from Triage - tag + prioritize. to To Do - Issues that are committed and up next. in PHP/C Engineering Board Feb 3, 2022
@mfulb mfulb moved this from To Do - Issues that are committed and up next. to Review in PHP/C Engineering Board Feb 3, 2022
@mfulb
Copy link
Contributor

mfulb commented Mar 1, 2022

Confirmed zts builds for 9.19 release.

@mfulb mfulb closed this as completed Mar 1, 2022
PHP/C Engineering Board automation moved this from Review to Done Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
PHP/C Engineering Board
  
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@joshuabenuck @Fahmy-Mohammed @zsistla @vupham-lc @mfulb