Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3.12 wheels to build #1022

Closed
wants to merge 1 commit into from
Closed

Add 3.12 wheels to build #1022

wants to merge 1 commit into from

Conversation

hmstepanek
Copy link
Contributor

@hmstepanek hmstepanek commented Jan 3, 2024

Overview

This PR fixes up some issues with supporting 3.12.

  • Add 3.12 into the list of wheel build envs.

@hmstepanek hmstepanek requested a review from a team as a code owner January 3, 2024 21:36
Copy link

github-actions bot commented Jan 3, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ YAML prettier 1 0 0 0.51s
✅ YAML v8r 1 0 2.09s
✅ YAML yamllint 1 0 0.22s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link
Contributor

@TimPansino TimPansino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change and this looks good

.github/containers/Dockerfile Outdated Show resolved Hide resolved
@hmstepanek hmstepanek changed the title Add 3.12 wheels to build & upgrade isort to support 3.12 Add 3.12 wheels to build Jan 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3314ae) 81.03% compared to head (3041393) 81.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1022      +/-   ##
==========================================
- Coverage   81.03%   81.01%   -0.03%     
==========================================
  Files         190      190              
  Lines       19640    19640              
  Branches     3431     3431              
==========================================
- Hits        15916    15912       -4     
- Misses       2732     2735       +3     
- Partials      992      993       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot removed the tests-failing label Jan 3, 2024
Copy link
Contributor

@TimPansino TimPansino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated or it won't have 3.12 support and the CI will crash.

@@ -57,7 +57,7 @@ jobs:
uses: pypa/cibuildwheel@v2.11.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: pypa/cibuildwheel@v2.11.1
uses: pypa/cibuildwheel@v2.16.2

@TimPansino
Copy link
Contributor

Reposting this comment

Closing this since this PR does it and more: #1024.

@TimPansino TimPansino closed this Jan 4, 2024
@TimPansino TimPansino deleted the fixup-3-12-support branch January 4, 2024 20:20
@umaannamalai umaannamalai added this to the v9.4.0 milestone Jan 4, 2024
@hmstepanek hmstepanek removed this from the v9.4.0 milestone Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants