Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config setting to toggle memory usage runtime metrics. #1122

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

umaannamalai
Copy link
Contributor

@umaannamalai umaannamalai commented Apr 10, 2024

The Python Agent reports a large volume of memory usage related metrics because it sends data up for each PID. This PR adds a setting to allow users to toggle memory usage metrics (per PID only) reporting to reduce overall metrics being sent.

@umaannamalai umaannamalai requested a review from a team as a code owner April 10, 2024 20:48
Copy link

github-actions bot commented Apr 10, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 3 0 5.51s
✅ PYTHON black 4 1 0 2.11s
✅ PYTHON flake8 4 0 0.94s
✅ PYTHON isort 4 2 0 0.26s
❌ PYTHON pylint 4 7 8.74s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@mergify mergify bot removed the tests-failing label Apr 11, 2024
Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a couple lint errors but otherwise looks good:

  /github/workspace/newrelic/core/config.py:142:1: E302 expected 2 blank lines, found 1
  /github/workspace/tests/agent_unittests/test_sampler_metrics.py:174:1: W391 blank line at end of file

@umaannamalai umaannamalai merged commit 240ea2e into main Apr 11, 2024
46 of 49 checks passed
@umaannamalai umaannamalai deleted the memory-usage-sampler-config branch April 11, 2024 18:25
@mergify mergify bot removed the tests-failing label Apr 11, 2024
@lrafeei lrafeei added this to the v9.9.0 milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants