Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default to pop to guard against key not found #1146

Merged
merged 4 commits into from
May 22, 2024
Merged

Conversation

hmstepanek
Copy link
Contributor

Overview

Pop needs a default value, otherwise it will raise an exception if the key is not found.

@hmstepanek hmstepanek requested a review from a team as a code owner May 20, 2024 18:41
@hmstepanek hmstepanek changed the title Add default to pop so does not raise if not found Add default to pop to guard against key not found May 20, 2024
Copy link

github-actions bot commented May 20, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 1 0 4.71s
✅ PYTHON black 1 0 0 1.08s
✅ PYTHON flake8 1 0 0.58s
✅ PYTHON isort 1 0 0 0.29s
✅ PYTHON pylint 1 0 3.86s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.45%. Comparing base (93ad043) to head (acd91f1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1146      +/-   ##
==========================================
- Coverage   81.71%   81.45%   -0.26%     
==========================================
  Files         192      192              
  Lines       21345    21345              
  Branches     3715     3715              
==========================================
- Hits        17442    17387      -55     
- Misses       2818     2869      +51     
- Partials     1085     1089       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmstepanek hmstepanek merged commit 8b79e6c into main May 22, 2024
45 of 51 checks passed
@hmstepanek hmstepanek deleted the fix-parsing-error branch May 22, 2024 00:15
@mergify mergify bot removed the tests-failing label May 22, 2024
@lrafeei lrafeei added this to the v9.10.0 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants