Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GraphQL master tests #1167

Merged
merged 8 commits into from
Jun 27, 2024
Merged

Enable GraphQL master tests #1167

merged 8 commits into from
Jun 27, 2024

Conversation

lrafeei
Copy link
Contributor

@lrafeei lrafeei commented Jun 20, 2024

This PR

  1. enables the testing of graphqlmaster. That is, it pulls graphql-core's code from the main branch as well as the latest release to make sure future releases of graphql-core do not conflict with New Relic's instrumentation/crash customer code
  2. adds/tweaks instrumentation to support graphql-core v3.3. Currently, this is still an alpha version
  3. updates GraphQL tests to support both v3.2 and v3.3+

@lrafeei lrafeei marked this pull request as ready for review June 20, 2024 18:09
@lrafeei lrafeei requested a review from a team as a code owner June 20, 2024 18:09
@mergify mergify bot removed the merge-conflicts label Jun 20, 2024
Copy link

github-actions bot commented Jun 20, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 2 0 5.77s
✅ PYTHON black 3 0 0 1.86s
✅ PYTHON flake8 3 0 0.97s
✅ PYTHON isort 3 0 0 0.26s
✅ PYTHON pylint 3 0 6.45s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

tests/framework_graphql/test_application.py Outdated Show resolved Hide resolved
tests/framework_graphql/test_application.py Outdated Show resolved Hide resolved
tests/framework_graphql/test_application.py Outdated Show resolved Hide resolved
tests/framework_graphql/test_application.py Outdated Show resolved Hide resolved
@lrafeei lrafeei requested a review from TimPansino June 24, 2024 22:21
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.66%. Comparing base (6e72cdf) to head (67d8ceb).

Files Patch % Lines
newrelic/hooks/framework_graphql.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1167      +/-   ##
==========================================
+ Coverage   81.65%   81.66%   +0.01%     
==========================================
  Files         195      195              
  Lines       21666    21667       +1     
  Branches     3780     3781       +1     
==========================================
+ Hits        17691    17694       +3     
  Misses       2877     2877              
+ Partials     1098     1096       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot removed the tests-failing label Jun 24, 2024
@lrafeei lrafeei requested a review from TimPansino June 26, 2024 22:56
@TimPansino TimPansino merged commit 541d126 into main Jun 27, 2024
52 checks passed
@TimPansino TimPansino deleted the graphql-testing-master branch June 27, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants