Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redis.asyncio.Connection instrumentation #919

Merged
merged 5 commits into from Sep 12, 2023
Merged

Conversation

lrafeei
Copy link
Contributor

@lrafeei lrafeei commented Sep 8, 2023

This PR

  • Adds instrumentation for redis.asyncio.Connection
  • Drops Flask support for Python 2.7 since the last version of Flask to support Python 2.7 (v1.1.2) is outside New Relic's supportability window (Since April 2022)

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 3 0 5.41s
✅ PYTHON black 4 0 0 1.36s
✅ PYTHON flake8 4 0 0.69s
✅ PYTHON isort 4 0 0 0.23s
✅ PYTHON pylint 4 0 9.26s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the tests-failing label Sep 8, 2023
@mergify mergify bot removed the tests-failing label Sep 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2023

Codecov Report

Merging #919 (060036b) into main (b1be563) will decrease coverage by 0.04%.
The diff coverage is 73.68%.

❗ Current head 060036b differs from pull request most recent head 6ad4c2e. Consider uploading reports for the commit 6ad4c2e to get more accurate results

@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
- Coverage   81.46%   81.43%   -0.04%     
==========================================
  Files         186      186              
  Lines       18700    18728      +28     
  Branches     3278     3289      +11     
==========================================
+ Hits        15234    15251      +17     
- Misses       2533     2536       +3     
- Partials      933      941       +8     
Files Changed Coverage Δ
newrelic/hooks/framework_flask.py 88.79% <ø> (-0.29%) ⬇️
newrelic/hooks/datastore_redis.py 84.82% <71.42%> (-4.37%) ⬇️
newrelic/config.py 71.29% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lrafeei lrafeei marked this pull request as ready for review September 12, 2023 18:27
@lrafeei lrafeei requested a review from a team as a code owner September 12, 2023 18:27
@lrafeei lrafeei merged commit e371b02 into main Sep 12, 2023
46 of 47 checks passed
@lrafeei lrafeei deleted the redis-asyncio-connection branch September 12, 2023 20:14
@mergify mergify bot removed the tests-failing label Sep 12, 2023
@umaannamalai umaannamalai added this to the v9.1.0 milestone Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants