Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add early exit conditional for streaming #988

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

hmstepanek
Copy link
Contributor

Overview

Adds an early exit conditional for streaming so we don't try to instrument during streaming right now.

@hmstepanek hmstepanek requested a review from a team as a code owner November 22, 2023 18:09
Copy link

github-actions bot commented Nov 22, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 1 0 4.74s
✅ PYTHON black 1 0 0 0.85s
✅ PYTHON flake8 1 0 0.51s
✅ PYTHON isort 1 0 0 0.18s
✅ PYTHON pylint 1 0 2.73s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop-ai-limited-preview@7d4828e). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             develop-ai-limited-preview     #988   +/-   ##
=============================================================
  Coverage                              ?   81.90%           
=============================================================
  Files                                 ?      191           
  Lines                                 ?    20022           
  Branches                              ?     3474           
=============================================================
  Hits                                  ?    16399           
  Misses                                ?     2626           
  Partials                              ?      997           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot removed the merge-conflicts label Dec 6, 2023
@hmstepanek hmstepanek merged commit 12a69f5 into develop-ai-limited-preview Dec 6, 2023
46 of 47 checks passed
@hmstepanek hmstepanek deleted the no-harm-streaming branch December 6, 2023 18:35
@mergify mergify bot removed the tests-failing label Dec 6, 2023
@umaannamalai umaannamalai added this to the v9.8.0 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants