Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable theo11y pack repo to accept contributions #8

Closed
12 tasks
jpvajda opened this issue May 6, 2021 · 8 comments · Fixed by #20
Closed
12 tasks

enable theo11y pack repo to accept contributions #8

jpvajda opened this issue May 6, 2021 · 8 comments · Fixed by #20

Comments

@jpvajda
Copy link
Contributor

jpvajda commented May 6, 2021

Details

The o11y pack repo needs to be setup to facilitate contributions from internal relics for Reli-Hack so we'll want to put in some basic github actions and ensure documentation is clear to facilitate contributions.

Acceptance Criteria

  • determine with @kidk what basics checks may be required.
  • provide feedback on the documentation and developer exp to @kidk.
  • look for basic automation opportunities in the process and implement those checks.
  • look for advanced automation opportunities int the process and make a new ticket to implement those checks in a future sprint.
  • Define JSON schema for dashboards
  • Define JSON schema for alerts
  • Define JSON schema for synthetics
  • Define overall JSON schema for o11y packs
  • Add PR template
  • Update contributing guide and include guidance on conventional commits
  • Add check for conventional commits on push
  • Add check for schema compliance on push
@jpvajda jpvajda transferred this issue from newrelic/nr1-quickstarts May 7, 2021
@jpvajda jpvajda added this to the [DevEn] Sprint 4 milestone May 7, 2021
@zstix zstix moved this from Tentative next to To do in Developer Enablement Team May 11, 2021
@jpvajda jpvajda added question Further information is requested and removed eng labels May 11, 2021
@jpvajda jpvajda self-assigned this May 11, 2021
@jpvajda jpvajda removed this from the [DevEn] Sprint 4 milestone May 11, 2021
@jpvajda
Copy link
Contributor Author

jpvajda commented May 11, 2021

@jpvajda I'll take this one.

@jpvajda jpvajda moved this from To do to Tentative next in Developer Enablement Team May 11, 2021
@jpvajda
Copy link
Contributor Author

jpvajda commented May 11, 2021

@kidk the DevEn teamed discussed this but it feels a little early to be able to try to attempt to build a pack as the repo seems to be unfinished and we have some pending architecture decisions. what do you think?

@jpvajda jpvajda moved this from Tentative next to In progress in Developer Enablement Team May 11, 2021
@jpvajda jpvajda added this to the [DevEn] Sprint 4 milestone May 11, 2021
@jpvajda jpvajda changed the title Build an actual O-Pack to provide feedback on the process Build an actual o11y pack to provide feedback on the process May 11, 2021
@jpvajda jpvajda changed the title Build an actual o11y pack to provide feedback on the process enable theo11y pack repo to accept contributions May 11, 2021
@jpvajda jpvajda removed their assignment May 11, 2021
@jpvajda jpvajda added eng and removed question Further information is requested labels May 11, 2021
@jpvajda jpvajda moved this from In progress to To do in Developer Enablement Team May 11, 2021
@jpvajda
Copy link
Contributor Author

jpvajda commented May 11, 2021

We discussed today with @kidk and I revised to be more about enable the repo for contributions vs. trying to build a pack.

@aswanson-nr aswanson-nr moved this from To do to In progress in Developer Enablement Team May 12, 2021
@aswanson-nr aswanson-nr self-assigned this May 12, 2021
@aswanson-nr
Copy link
Contributor

aswanson-nr commented May 12, 2021

@jpvajda / @kidk I'm sure I'm missing some information, but build/deployment seem like hard requirements before we can accept contributions. Otherwise, we have no way to validate the pack.

All that being said, there are a few things we can get started with:

  • Update the CONTRIBUTING guide, it looks like we just have the default
  • Document that conventional commits should be used (we are using them, right?)
  • Add a PR template
  • Add a job to verify that all commits are conventional on push
  • Add a job to check YAML syntax on push
  • Add a job to verify pack structure
    • this might be something that the CLI does, but if the CLI won't be ready then we should add something even if it's pretty basic

@aswanson-nr aswanson-nr added the question Further information is requested label May 12, 2021
@aswanson-nr aswanson-nr moved this from In progress to In review in Developer Enablement Team May 12, 2021
@jpvajda
Copy link
Contributor Author

jpvajda commented May 12, 2021

@aswanson-nr those all sound like actionable steps, let's do it as part of this ticket.

@aswanson-nr aswanson-nr moved this from In review to In progress in Developer Enablement Team May 12, 2021
@aswanson-nr aswanson-nr removed the question Further information is requested label May 12, 2021
@zstix
Copy link
Contributor

zstix commented May 13, 2021

After speaking with @aswanson-nr, I think we have a clear direction on acceptance criteria:

Acceptance Criteria

  • Update the CONTRIBUTING guide, it looks like we just have the default
  • Document that conventional commits should be used (perhaps part of contributing guide)
  • Add a PR template
  • Add a pre-commit-hook to verify that all commits are conventional
  • Add a job to check that the YAML is valid and has the just currently-defined required fields (listed below)

Minimum Required Configuration (Currently)

  • Observability Packs
    • name
    • level (although this might not be necessary - no level could mean community)
  • Alerts (if present)
    • name
    • type
    • nrql (if we don't also support apm & synthetics alerts)
  • Dashboard (if present)
    • name
  • Flex (if present)
    • name
    • integrations (is this required?)
  • Synthetics (if present)
    • name
    • type (we should consider adding this for other types (e.g. pings))

@aswanson-nr aswanson-nr mentioned this issue May 17, 2021
6 tasks
@moonlight-komorebi moonlight-komorebi self-assigned this May 17, 2021
@aswanson-nr aswanson-nr moved this from In progress to In review in Developer Enablement Team May 19, 2021
Developer Enablement Team automation moved this from In review to Done May 20, 2021
@aswanson-nr
Copy link
Contributor

Reopening because the workflow does not run on a forked PR.

@aswanson-nr aswanson-nr reopened this May 20, 2021
Developer Enablement Team automation moved this from Done to In progress May 20, 2021
@aswanson-nr
Copy link
Contributor

I have confirmed that the workflow behaves properly during a fork PR

Developer Enablement Team automation moved this from In progress to Done May 21, 2021
LizBaker added a commit to LizBaker/newrelic-observability-packs that referenced this issue Feb 4, 2022
josephgregoryii pushed a commit that referenced this issue Nov 2, 2022
Merge Group 7 for the Infra Dashboard Template Migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment