Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Update perf tests workflow to address deprecation issues #2211

Open
fallwith opened this issue Sep 13, 2023 · 2 comments
Open

CI: Update perf tests workflow to address deprecation issues #2211

fallwith opened this issue Sep 13, 2023 · 2 comments
Labels
2 Story Point Estimate

Comments

@fallwith
Copy link
Contributor

Our GHA based CI workflow for performance testing is currently warning us of 2 issues:

  • 3rd party action adrey/slack-file-upload-action is running on Node v12, but should be on v16+.
  • The use of the set-output command is deprecated

We should address these.

[run_performance_tests](https://github.com/newrelic/newrelic-ruby-agent/actions/runs/6166750653/job/16736709122)
The following actions uses node12 which is deprecated and will be forced to run on node16: adrey/slack-file-upload-action@903be3678c88966c762193f06530c39178b44d68. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

[run_performance_tests](https://github.com/newrelic/newrelic-ruby-agent/actions/runs/6166750653/job/16736709122#step:10:7)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
@fallwith fallwith added estimate Issue needing estimation oct-dec qtr Possible FY Q3 candidate labels Sep 13, 2023
@workato-integration
Copy link

https://issues.newrelic.com/browse/NR-160282

@kford-newrelic kford-newrelic added 2 Story Point Estimate and removed estimate Issue needing estimation labels Sep 24, 2023
@kford-newrelic kford-newrelic added jan-mar qtr Possible FY Q4 candidate and removed oct-dec qtr Possible FY Q3 candidate labels Oct 2, 2023
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-160282

@kford-newrelic kford-newrelic removed the jan-mar qtr Possible FY Q4 candidate label Jan 10, 2024
@kaylareopelle kaylareopelle mentioned this issue Apr 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 Story Point Estimate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fallwith @kford-newrelic