Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perhaps the install command could be improved #315

Closed
flanger001 opened this issue Feb 3, 2020 · 4 comments
Closed

Perhaps the install command could be improved #315

flanger001 opened this issue Feb 3, 2020 · 4 comments
Labels

Comments

@flanger001
Copy link

Steps to recreate:

  • Have an app with an existing newrelic.yml
  • Run newrelic install with any options
newrelic.yml file already exists.  Move it out of the way.

https://github.com/newrelic/rpm/blob/17734c85a9251ede14fbee517f0d264d99116c7e/lib/new_relic/cli/commands/install.rb#L44

The language could be less blunt, and also this could give the option of overwriting the file instead.

@rachelleahklein
Copy link

Hi @flanger001, we'll look into the improvement you've suggested - certainly the wording could be kinder, I agree! Thanks for bringing it up.

@flanger001
Copy link
Author

Thanks @rachelleahklein! I think the more useful thing here would be my second point of optionally overwriting the file. I think it's probably a safe assumption that this file will be in VC.

@mwlang
Copy link
Contributor

mwlang commented Feb 20, 2020

@flanger001 Thank you for your suggestion. We have improved newrelic install with a --force flag and improved messaging. This will be available in the next release after 6.9.0.

@mwlang mwlang closed this as completed Feb 20, 2020
@flanger001
Copy link
Author

Thank you @mwlang!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants