Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser_monitoring.auto_instrument is duplicated in the a "clean" newrelic.yml #955

Closed
robotfelix opened this issue Feb 14, 2022 · 1 comment · Fixed by #992
Closed

browser_monitoring.auto_instrument is duplicated in the a "clean" newrelic.yml #955

robotfelix opened this issue Feb 14, 2022 · 1 comment · Fixed by #992
Labels
community To tag external issues and PRs submitted by the community technical debt

Comments

@robotfelix
Copy link

Description

I'm just in the middle of updating our New Relic ruby agent version. I downloaded a clean newrelic.yml from the Account Settings page in the web interface and noticed that the browser_monitoring.auto_instrument config option is included twice, with ever-so-slightly different documentation and different commented values.

This issue can be seen in the newrelic.yml file on the master branch here:

# If true, enables auto-injection of the JavaScript header for page load timing
# (sometimes referred to as real user monitoring or RUM).
# browser_monitoring.auto_instrument: false
# This is true by default, this enables auto-injection of the JavaScript header
# for page load timing (sometimes referred to as real user monitoring or RUM).
# browser_monitoring.auto_instrument: true

Expected Behavior

browser_monitoring.auto_instrument appears once in newrelic.yml. I don't feel qualified to say whether the comment value should be false or true.

Troubleshooting or [NR Diag]

N/A - no real trouble!

Steps to Reproduce

N/A - documentation / template config issue only

Your Environment

N/A

Additional context

N/A

@robotfelix robotfelix added the bug label Feb 14, 2022
@github-actions github-actions bot added the community To tag external issues and PRs submitted by the community label Feb 14, 2022
@tannalynn
Copy link
Contributor

Good catch! Thanks for letting us know, we'll take a look and get that updated.

fallwith added a commit that referenced this issue Feb 24, 2022
removed duplicate `browser_monitoring.auto_instrument` from
`newrelic.yml`. This configuration option (for RUM) defaults to `true`
and is appropriately commented out in the config so as to not be
redundantly applied. The confusing duplicated config file entry with a
`false` value (also commented out) has now been removed.

resolves #955
Ruby Engineering Board automation moved this from Triage to Done/Pending Release Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community To tag external issues and PRs submitted by the community technical debt
Projects
Archived in project
Ruby Engineering Board
  
Code Complete/Done
Development

Successfully merging a pull request may close this issue.

3 participants