Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the current transaction id with errors #2035

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Conversation

fallwith
Copy link
Contributor

If a transaction can be found in the current context while noticing an error, include that transaction's guid in the array that is JSON-ified for reporting later.

If a transaction can be found in the current context while noticing an
error, include that transaction's guid in the array that is JSON-ified
for reporting later.
@github-actions
Copy link

SimpleCov Report

Coverage Threshold
Line 94.26% 94%
Branch 85.76% 85%

improve the English error message
@fallwith fallwith marked this pull request as ready for review July 18, 2023 19:58
@fallwith
Copy link
Contributor Author

resolves #2036

Copy link
Contributor

@tannalynn tannalynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@fallwith fallwith merged commit 8ab260e into dev Jul 18, 2023
26 checks passed
@fallwith fallwith deleted the txn_guid_in_error_json branch July 18, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants