Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include test/agent_helper.rb in build #2115

Merged
merged 2 commits into from Jul 10, 2023

Conversation

kaylareopelle
Copy link
Contributor

@kaylareopelle kaylareopelle commented Jul 5, 2023

The test/agent_helper.rb file was overlooked in our switch to the new file inclusion process introduced in
#2089

This file is required for the public API
NewRelic::Agent.require_test_helper.

The file has been added back to the build. Furthermore, build.rb was still included. This file used to be generated with Jenkins during our release process and has not been created with a release since version 6.13.0.

Resolves #2113

The test/agent_helper.rb file was overlooked in our switch to the new
file inclusion process introduced in PR#2089
#2089

This file is required for the public API
NewRelic::Agent.require_test_helper.

Furthermore, build.rb was still included. This file used to be
generated with Jenkins during our release process and has not been
created with a release since version 6.13.0.
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

SimpleCov Report

Coverage Threshold
Line 94.26% 94%
Branch 85.77% 85%

fallwith
fallwith previously approved these changes Jul 7, 2023
@kaylareopelle kaylareopelle marked this pull request as ready for review July 10, 2023 19:05
@kaylareopelle kaylareopelle merged commit 5e81f98 into dev Jul 10, 2023
25 of 26 checks passed
@kaylareopelle kaylareopelle deleted the bugfix/2113-include-test-agent-helper branch July 10, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change from 9.2.2 to 9.3.0 due to /test/agent_helper.rb no longer being included in the gem
4 participants