Create test for agent_helper in gem files #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaylareopelle
commented
Jul 7, 2023
| # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details. | ||
| # frozen_string_literal: true | ||
|
|
||
| require 'minitest/autorun' |
There was a problem hiding this comment.
@ajesler - I swapped out the test_helper require statement with minitest/autorun because we don't want/need the agent to be loaded for this particular test.
This is what we do with our other utilities, like our CveNotifierTests
kaylareopelle
requested review from
fallwith,
hannahramadan and
tannalynn
as code owners
fallwith
previously approved these changes
Jul 10, 2023
Co-authored-by: AJ Esler <aj@esler.co.nz>
kaylareopelle
force-pushed
the
2117_gemspec_test
branch
from
bdccfd4
to
4049ec6
Compare
fallwith
previously approved these changes
Jul 11, 2023
|
Hmm... local tests and the CI aren't matching. I'm going to come back to this after the release. |
effectively fork `Gem::Specification.load` to bypass its internal caching mechanism, and catch parse failures with an assertion.
When parsing `newrelic_rpm.gemspec` from a directory other than the project root, make sure that the `.build_ignore` file can be found by leveraging its absolute path
We were previously skipping the `rails<version>` env tests, but not the `norails` ones. Skip those too.
The automated CI tests only run the 'env' suites, so we can't skip `norails`. Instead, just chdir to the root of the agent dir, which is where any production targetting `gem build` process will take place.
Skip older Rubygems based contexts
CI: gemspec files test - bypass cache
fallwith
approved these changes
Jul 11, 2023
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test to ensure the
test/agent_helper.rbfile is included in the distributed gem.Thank you, @ajesler for your creative solution! 馃寛
Resolves #2117