Record status codes when middleware instrumentation is disabled #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
middleware instrumentation is disabled
recorded when middleware instrumentation is disabled
tannalynn
requested review from
fallwith,
hannahramadan and
kaylareopelle
as code owners
fallwith
reviewed
Aug 22, 2023
Co-authored-by: James Bunch <fallwith@gmail.com>
Co-authored-by: James Bunch <fallwith@gmail.com>
…ub.com:newrelic/newrelic-ruby-agent into status_code_without_middleware_instrumentation
Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
hannahramadan
previously approved these changes
Aug 22, 2023
Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
SimpleCov Report
|
kaylareopelle
approved these changes
Aug 22, 2023
fallwith
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the check for
disable_middleware_instrumentationwhen recording the http status code. Previously the agent would skip recording it if the middleware instrumentation was disabled due to the possibility that a middleware not being instrumented could alter the response. However, we've decided to change this behavior due to customer feedback. Now, the status code will always be recorded to the transaction if available.Also, I fixed an old bug in
AgentHooks.needed?, the logic was inverted, prevent the agent hooks from being used at the correct time.resolves #2149