Add synthetics info header #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannalynn
requested review from
fallwith,
hannahramadan and
kaylareopelle
as code owners
Comment on lines
+86
to
+88
| def snakeize(string) | ||
| string.gsub(/(.)([A-Z])/, '\1_\2').downcase | ||
| end |
There was a problem hiding this comment.
Nice! We have a language support test file. Could you add tests for this method to it?
There was a problem hiding this comment.
added a test for this here 436f5d2
There was a problem hiding this comment.
I like the name of this method 🐍
fallwith
reviewed
Sep 21, 2023
kaylareopelle
previously approved these changes
Sep 22, 2023
kaylareopelle
previously approved these changes
Sep 22, 2023
Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
SimpleCov Report
|
fallwith
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the logic for handling the new synthetics header,
X-NewRelic-Synthetics-Info, adding the attributes to the transaction as intrinsic attributes, and adds the header to outgoing external request headers. These attributes are included in transaction events and error events. They will also automatically be included in transaction/error traces, as those include all intrinsic attributes already.spec
closes #2055