Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ViewComponent instrumentation #2367

Merged
merged 10 commits into from Jan 8, 2024
Merged

ViewComponent instrumentation #2367

merged 10 commits into from Jan 8, 2024

Commits on Jan 8, 2024

  1. ViewComponent base instrumentation

    @hannahramadan
    Hannah Ramadan authored and hannahramadan committed Jan 8, 2024
    Copy the full SHA
    318683c View commit details
    Browse the repository at this point in the history

  2. Code review edits

    @hannahramadan
    Hannah Ramadan authored and hannahramadan committed Jan 8, 2024
    Copy the full SHA
    b101b88 View commit details
    Browse the repository at this point in the history

  3. Config update

    @hannahramadan
    Hannah Ramadan authored and hannahramadan committed Jan 8, 2024
    Copy the full SHA
    427ad20 View commit details
    Browse the repository at this point in the history

  4. ViewComponent tests 

    Inline disable rubocop

Cleanup tests

Appease rubocop
    @hannahramadan
    Hannah Ramadan authored and hannahramadan committed Jan 8, 2024
    Copy the full SHA
    d57e3e9 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>

Code feedback

Add mistakenly deleted file

Move file

Test update

Test updates

Use newer vc version
    @hannahramadan
    hannahramadan committed Jan 8, 2024
    Copy the full SHA
    d746f68 View commit details
    Browse the repository at this point in the history

  6. Add CHANGELOG

    @hannahramadan
    hannahramadan committed Jan 8, 2024
    Copy the full SHA
    732d23f View commit details
    Browse the repository at this point in the history

  7. test version change 

    version change

Only test latest version
    @hannahramadan
    hannahramadan committed Jan 8, 2024
    Copy the full SHA
    d115441 View commit details
    Browse the repository at this point in the history

  8. Add yield

    @hannahramadan
    hannahramadan committed Jan 8, 2024
    Copy the full SHA
    70c3c77 View commit details
    Browse the repository at this point in the history

  9. Update tests and version test 

    Version fix
    @hannahramadan
    hannahramadan committed Jan 8, 2024
    Copy the full SHA
    a0e188c View commit details
    Browse the repository at this point in the history

  10. Merge branch 'dev' into view_component

    @tannalynn
    tannalynn committed Jan 8, 2024
    Copy the full SHA
    5ebc4ef View commit details
    Browse the repository at this point in the history