Falcon instrumentation #2383
Merged
Falcon instrumentation #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahramadan
commented
Jan 3, 2024
lib/new_relic/local_environment.rb
Outdated
| @@ -138,6 +139,13 @@ def check_for_puma | |||
| end | |||
| end | |||
|
|
|||
| def check_for_falcon | |||
| if defined?(::Falcon::Server) && NewRelic::LanguageSupport.object_space_usable? | |||
| v = find_class_in_object_space(::Falcon::Server) | |||
There was a problem hiding this comment.
A similar object space check that we do for Unicorn and Thin.
hannahramadan
requested review from
fallwith,
kaylareopelle and
tannalynn
as code owners
tannalynn
reviewed
Jan 4, 2024
fallwith
reviewed
Jan 4, 2024
Co-authored-by: James Bunch <fallwith@gmail.com>
fallwith
reviewed
Jan 4, 2024
| @@ -10,7 +10,7 @@ module SpecialStartup | |||
| # requests, we need to wait until the children are forked | |||
| # before connecting, otherwise the parent process sends useless data | |||
| def using_forking_dispatcher? | |||
| if [:puma, :passenger, :unicorn].include?(Agent.config[:dispatcher]) | |||
| if [:puma, :passenger, :unicorn, :falcon].include?(Agent.config[:dispatcher]) | |||
There was a problem hiding this comment.
Falcon was added to this list because of its ability to fork. Falcon can also run in a threaded mode instead of a forking one, but given that:
There is no guarantee that your process would be forked or threaded.
It makes sense to always defer when Falcon is in play.
fallwith
reviewed
Jan 4, 2024
fallwith
approved these changes
Jan 4, 2024
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The agent will now report Falcon as a recognized webserver.
Closes #2188
Note: This PR defers adding tests to a separate ticket.