Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce gem package size #458

Merged
merged 1 commit into from Sep 30, 2020
Merged

Reduce gem package size #458

merged 1 commit into from Sep 30, 2020

Conversation

pocke
Copy link
Contributor

@pocke pocke commented Sep 26, 2020

Before contributing, please read our contributing guidelines and code of conduct.

Overview

This pull request reduces gem package size.

Currently newrelic_rpm gem package is 4.5MB after unzip. We can confirm the size with du command.
For example

$ cd path/to/installed/dir/lib/ruby/gems/2.7.0/gems
$ du newrelic_rpm-6.13.1/ --summarize -h
4.5M    newrelic_rpm-6.13.1/

And .github directory occupies half of the size.

# in the same directory
$ du newrelic_rpm-6.13.1/* --summarize -b | sort -n | tail
7933    newrelic_rpm-6.13.1/README.md
9317    newrelic_rpm-6.13.1/config.dot
11571   newrelic_rpm-6.13.1/LICENSE
13169   newrelic_rpm-6.13.1/bin/
17626   newrelic_rpm-6.13.1/THIRD_PARTY_NOTICES.md
33302   newrelic_rpm-6.13.1/test/
69358   newrelic_rpm-6.13.1/cert/
177295  newrelic_rpm-6.13.1/CHANGELOG.md
1285344 newrelic_rpm-6.13.1/lib/
2178011 newrelic_rpm-6.13.1/.github/

But .github directory is not necessary for the package users. So this pull request removes the .github directory from the gem package.
It reduces 2.2MB package size.

# In the same directory
$ du newrelic_rpm-6.13.1/ --summarize -h
2.3M    newrelic_rpm-6.13.1/

Related Github Issue

nothing

Testing

I've confirmed the existing test suites are all green.

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2020

CLA assistant check
All committers have signed the CLA.

@mwlang mwlang self-assigned this Sep 30, 2020
@mwlang mwlang added this to In progress in Ruby Engineering Board via automation Sep 30, 2020
Copy link
Contributor

@mwlang mwlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- removes .github from the manifest, which is where the Github Actions workflow files live and have no bearing on the packaged gem file.

@mwlang mwlang merged commit 530362a into newrelic:dev Sep 30, 2020
Ruby Engineering Board automation moved this from In progress to Done/Pending Release Sep 30, 2020
@pocke pocke deleted the reduce-package-size branch September 30, 2020 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Ruby Engineering Board
  
Code Complete/Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants