Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] update jdbc adapters #922

Merged
merged 1 commit into from Jan 27, 2022
Merged

[ci] update jdbc adapters #922

merged 1 commit into from Jan 27, 2022

Conversation

ahorek
Copy link
Contributor

@ahorek ahorek commented Jan 25, 2022

Overview

this PR adds suitable versions of jdbc adapters to rails 5.2 - 6.1 gemfiles

  • rails 7 isn't supported on jruby yet

Related Github Issue

Testing

Reviewer Checklist

  • Perform code review
  • Add performance label
  • Perform appropriate level of performance testing
  • Confirm all checks passed
  • Add version label prior to acceptance

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

kaylareopelle
kaylareopelle approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating these gem versions! We'll keep an eye out for the Rails 7 release!

@kaylareopelle kaylareopelle merged commit 6654e1c into newrelic:dev Jan 27, 2022
@kaylareopelle kaylareopelle added this to In progress in Ruby Engineering Board via automation Jan 27, 2022
@kaylareopelle kaylareopelle moved this from In progress to Done/Pending Release in Ruby Engineering Board Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaylareopelle kaylareopelle kaylareopelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Ruby Engineering Board
Archived in project
Ruby Engineering Board
  
Code Complete/Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahorek @CLAassistant @kaylareopelle