Add new metric types #13
Conversation
add rate and cumulative-rate
| // timestamps of multiple calls. If this is the first time the name/attributes | ||
| // combination has been seen then the `valid` return value will be false. | ||
| func (dc *DeltaCalculator) CountMetric(name string, attributes map[string]interface{}, val float64, now time.Time) (count telemetry.Count, valid bool) { | ||
| func (dc *DeltaCalculator) GetCumulativeCount(name string, attributes map[string]interface{}, val float64, now time.Time) (count telemetry.Count, valid bool) { |
There was a problem hiding this comment.
This is a backwards incompatible change and it does not appear to be warranted. 👎
| @@ -0,0 +1,15 @@ | |||
| package internal | |||
There was a problem hiding this comment.
Creating an internal package is not adding any benefit. It is encapsulating already un-exported structures and does not add naming/functional benefit.
| // If no previous timestamp is NOT found, returns false (as no calculation is made) | ||
| // If a previous timestamp is found use it to get the elapsed time (in seconds) and use that as the denominator | ||
| // Rate = value / (now - before)[s] | ||
| func (rc *RateCalculator) GetRate(name string, attributes map[string]interface{}, val float64, now time.Time) (gauge telemetry.Gauge, valid bool) { |
There was a problem hiding this comment.
Exporting a rate from a remote location only serves to decrease the usability of this data. You cannot reverse this operation without also transmitting the time interval it was calculated with. New Relic has the functionality to take one of the existing Metrics and calculate rates (as well as other computed values) from these.
Additionally, this would add an inconsistency in this telemetry-sdks API from the rest of the New Relic telemetry-sdks. If we want to add this metric type it need to be addressed in the specification
|
We have moved the calculations into the agent |
Add new metric calculation for